-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trunner: prevent the screen from clear by escape code in output from fail #358
base: master
Are you sure you want to change the base?
trunner: prevent the screen from clear by escape code in output from fail #358
Conversation
Unit Test Results7 484 tests - 241 6 769 ✅ - 241 38m 21s ⏱️ + 1m 17s Results for commit 933c44c. ± Comparison against base commit aba8104. This pull request removes 241 tests.
♻️ This comment has been updated with latest results. |
c49e59c
to
a749936
Compare
Why? IMHO on error we should show data as-is (even garbage) as it might be a part of (or a reason for) an error? The regex is slightly invalid, also we already have |
The name of task suggested that we could skip clear screen esc code - I didn't mean to escape all of them. I was considering such solution, because we are running tests using trunner on images that refresh, clear and print the whole output once again and again. Then in case of fail the output is not readable |
a749936
to
efc7483
Compare
efc7483
to
e4c83fe
Compare
e4c83fe
to
c5c82f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
About the commit message: That's very clear, but a bit too long, let's make it shorter. You can add a quick explanation in commit description why are we adding this.
Ensures that escape codes in output don't clear the screen when a failure occurs. JIRA: CI-460
c5c82f6
to
933c44c
Compare
I still don't get it, the log should be as verbose as it could (if we're removing data from the output we might remove why regex match has failed) . If we're talking about better presentation on screen - it should be done at a different level (just before printing message to screen)? Also please note that current implementation is slow - using simple |
JIRA: CI-460
Description
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment